[release-1.12] 📖 docs: machinepool contract spec #13098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds documentation that details the contract for providers when implementing an infrastructure machine pool. This has been created retrospectively from looking at a number of providers and the MachinePool controller. Signed-off-by: Richard Case <richard.case@outlook.com>
Changes after the first review by Fabrizio. Signed-off-by: Richard Case <richard.case@outlook.com>
Changes after the first review by Fabrizio. Signed-off-by: Richard Case <richard.case@outlook.com>
Some updates after an additional review by Andreas. Signed-off-by: Richard Case <richard.case@outlook.com>
Various updates after review by Fabrizio and Andreas. Specifically: - Making it clearer what is preferred state vs current deprecated - Rewording some parts to be clearer. Signed-off-by: Richard Case <richard.case@outlook.com>
k8s-ci-robot added size/XL 
fabriziopandini added the tide/merge-method-squash 
Member
| /area machinepool |
k8s-ci-robot added area/machinepool Member
| /lgtm |
k8s-ci-robot added the lgtm 
Contributor
| LGTM label has been added. Git tree hash: dde5e09f5f52d3dac1e4af9bb1c054978a5a409d |
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12971
/assign fabriziopandini