Improving zip strides error message #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The way the strides error message work is that two slices could have the same strides when packed and it could trigger. Just making the error message more clear that the slices need to have the same strides when unpacked.
Member
| PR please! |
Member
| Ah, sorry. This is already a PR) |
Codecov Report
@@ Coverage Diff @@ ## master #61 +/- ## ======================================= Coverage 96.33% 96.33% ======================================= Files 28 28 Lines 4750 4750 ======================================= Hits 4576 4576 Misses 174 174
Continue to review full report at Codecov.
|
Member
| ping @jmh530 |
Contributor Author
| @9il Does this need additional work? |
Member
| Only remove addition space |
Contributor Author
| Arg, I didn't do this through the fork. I might need to close this and open a new one to fix it. |
Contributor Author
| Replacing with #71. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The way the strides error message work is that two slices could have the same strides when packed and it could trigger. Just making the error message more clear that the slices need to have the same strides when unpacked.