Rename ContiguousTensor/CanonicalTensor/UniversalTensor #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Rename ContiguousTensor/CanonicalTensor/UniversalTensor to ContiguousSlice/CanonicalSlice/UniversalSlice
Remove previous usage of ContiguousTensor, UniversalTensor, Canonical tensor in slice.d
Remove previous usage of ContiguousTensor, UniversalTensor, Canonical tensor in package.d
Remove previous usage of ContiguousTensor in allocation.d
jmh530 changed the title 
Codecov Report
@@ Coverage Diff @@ ## master #67 +/- ## ======================================= Coverage 96.33% 96.33% ======================================= Files 28 28 Lines 4750 4750 ======================================= Hits 4576 4576 Misses 174 174
Continue to review full report at Codecov.
|
Member
| Please use deprecation in 2019 instead of breaking changes |
Contributor Author
| @9il I assume you meant "in 2017"? Anyway, added the deprecation warning. I will make an effort to remember this from now on. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Merging branch to rename ContiguousTensor, CanonicalTensor, and UniversalTensor to ContiguousSlice, CanonicalSlice, and UniversalSlice and adjust all other usage of the original terminology.
This pull request intends to address issue 64.