Add in packsOf alias for isSlice #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #72 +/- ## ========================================== + Coverage 96.33% 96.33% +<.01% ========================================== Files 28 28 Lines 4750 4751 +1 ========================================== + Hits 4576 4577 +1 Misses 174 174
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #66 that I created.
The
isSlicefunction currently performs double-duty, also returning packs information. This change adds in an aliaspacksOffor isSlice. Other adjustments change the behavior where isSlice is currently used.Update of previous PR #68 (had deleted to clean up my fork, b/c I am git idiot).