Added purity markers for enumerables, improved type definitions

[Ocramius]

This patch introduces a few improvements on the codebase:

• adds vimeo/psalm minimal tests (not testing sources, just declared API)
• adds @psalm-pure and @psalm-immutable to enumerable types, allowing usage of Enum in functionally pure (type-checked) contexts
• add better type declarations where refinements are possible (such as non-empty-string vs string, where applicable)
• removes some exported files from dist package (noticed because I wanted to exclude psalm.xml from exports)

I kept very conservative on type definitions: I wanted to restrict also on ::has() and ::get(), but that would introduce downstream issues, such as ::has($unknown) failing due to missing upfront assertions.

Note: this is compatible with #138 too.

[Ocramius]

Not sure what happened here: was the file commited with \r\n before?

[marc-mabe]

No idea how this happened

[Ocramius]

This is the only addition here

[Ocramius]

Succeeded: not sure why CI failed to report status.

https://travis-ci.org/github/marc-mabe/php-enum/builds/670092398

[Ocramius]

✔️ https://travis-ci.org/github/marc-mabe/php-enum/builds/670098448

[marc-mabe]

Thanks @Ocramius,
I highly appreciate your contribution 👍

[Ocramius]

Awesome, thanks! \o/ Could you cut a minor with this one, when you got time? Thanks! Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/

…

On Sun, Apr 5, 2020 at 12:44 PM Marc Bennewitz ***@***.***> wrote: Merged #140 <#140> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#140 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEAUP2UEARDOFSBEMF3RLBOHJANCNFSM4L2JRIPQ> .

[marc-mabe]

Hi @Ocramius,
I have created an RC release now including generic types.
Please check if everything works as expected.

[Ocramius]

Trying it out, thanks!

[Ocramius]

Tried on a downstream codebase that relies on vimeo/psalm: seems to be all good, although I didn't add any specific types that rely on the new generics :-)

[marc-mabe]

Thanks!
I'll try that on two projects using PHPStan this week and if everything is fine I create a stable release.