Skip to content

Conversation

@danditomaso
Copy link
Collaborator

Description

This PR adds the language switcher control back to the connections page, it was removed during a refactor of the page and this will restore its functionality.

Screenshots (if applicable)

image

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)
Copilot AI review requested due to automatic review settings November 13, 2025 17:25
@vercel
Copy link

vercel bot commented Nov 13, 2025

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

Copilot finished reviewing on behalf of danditomaso November 13, 2025 17:28
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web-test Ready Ready Preview Comment Nov 13, 2025 5:29pm
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the language switcher component to the Connections page header after it was accidentally removed during a previous refactor. The changes include adding the component back to the page and refactoring the translation key structure.

  • Added LanguageSwitcher component back to the Connections page header
  • Modified layout from horizontal to vertical flex to accommodate both the "Add Connection" button and language switcher
  • Refactored translation key from language.changeLanguage to languagePicker.label for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/web/src/pages/Connections/index.tsx Added LanguageSwitcher import and component to header, changed flex layout from row to column
packages/web/src/components/LanguageSwitcher.tsx Updated translation import and changed key from language.changeLanguage to languagePicker.label
packages/web/public/i18n/locales/en/ui.json Renamed translation key structure from language to languagePicker, removed changeLanguage subkey

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 184 to 186
"languagePicker": {
"label": "Language"
},
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key structure was changed from language to languagePicker, but the old language.changeLanguage key is still referenced in packages/web/src/components/DeviceInfoPanel.tsx at line 138. This change will cause a missing translation for that component.

Additionally, all other locale files (de-DE, es-ES, fr-FR, etc.) still have the old language key structure and do not have the new languagePicker key. This means the language switcher will not be properly translated for non-English users.

Copilot uses AI. Check for mistakes.
@danditomaso danditomaso merged commit 390b46f into meshtastic:main Nov 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant