Reduce compute units consumption #1074
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
blockiosaurus approved these changes Apr 25, 2023
Contributor
blockiosaurus left a comment
blockiosaurus left a comment There was a problem hiding this comment.
This is awesome! Good work!
| invoke_signed( | ||
| &system_instruction::assign(new_account_info.key, &program_id), | ||
| accounts, | ||
| &system_instruction::create_account( |
| BorshSerialize::serialize(&self, &mut bytes)?; | ||
| | ||
| let data = &mut account.data.borrow_mut(); | ||
| data[..bytes.len()].copy_from_slice(&bytes); |
Contributor
There was a problem hiding this comment.
I feel like we talked about this before, but is this better or worse than sol_memcpy?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR optimizes the compute units usage on the unified
createinstruction.