Skip to content

Conversation

@Lightning00Blade
Copy link
Contributor

@Lightning00Blade Lightning00Blade commented Oct 21, 2025

PR Checklist

Overview

Updates rollup to v4.
This change is needed for the EsLint v9 bump - #5483.

Notable changes drops rollup-plugin-node-global and uses rollup-plugin-polyfill-node unconditionally.

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.69%. Comparing base (f4d4ad2) to head (b86cb41).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #5510 +/- ## ======================================= Coverage 93.69% 93.69% ======================================= Files 57 57 Lines 4396 4396 Branches 849 849 ======================================= Hits 4119 4119 Misses 277 277 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
format
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting some first thoughts for now, I'll need to review Rollup in more detail and test this locally to see what's going on. Might be a week-ish, I usually prioritize bugfixes first.

@mark-wiemer
Copy link
Member

PR is actually quite small and tests are still passing. (99% of lines changed are in package-lock.json)

Curious for @JoshuaKGoldberg's thoughts on this, I'll review tmrw in more detail.

@mark-wiemer mark-wiemer added this to the v12.0.0 milestone Nov 22, 2025
@mark-wiemer mark-wiemer changed the title build: update Rollup to v4 repo: update Rollup to v4 Nov 22, 2025
Lightning00Blade and others added 2 commits November 25, 2025 10:06
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Copy link
Member

@mark-wiemer mark-wiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mark-wiemer mark-wiemer merged commit cafa782 into mochajs:main Dec 4, 2025
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants