GridStore.seek fails to change chunks and call callback when in read mode #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| can you provide a test to cover the scenario then I'll merge it in |
Author
| Can do. |
Contributor
| merged in changes using cherry-pick so they are in the commit log :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current logic tests to see if our seek moves the position between chunks, if this is the case, it first saves the current chunk if in write mode, and then loads the next necessary chunk. However, if the file is opened in read mode, the logic is missing, so the callback is never called.
I'm patching this by pulling the chunk loading into a function which gets called either from within the callback to the chunk save, or the else condition.