Allow URL encoded passwords with db.connect() #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
christkv added a commit that referenced this pull request Mar 12, 2012
Allow URL encoded passwords with db.connect()
Contributor
| have to back out this as generated passwords might have url characters in them |
Contributor Author
| We were dealing with autogenerated passwords with @ and other stuff in them. Requiring people to form proper URLs doesn't seem so bad, is it breaking peoples' stuff? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is just a small change that URL decodes usernames and passwords in connection URLs.
I'd like make that function use the built in URL parsing in Node, would that be ok with you? Regex's give me hives. :)