Make callback type checks agnostic to V8 context boundaries #545
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If a node.js application that uses MongoDB is executed with NODE_MODULE_CONTEXTS=1 environment variable (which causes each userland module to be loaded in its own V8 context), several checks for the type of the callback argument in MongoDB fail even though they should semantically pass.
For detailed description of the root cause see http://tomasz.janczuk.org/2012/03/when-javascript-function-is-not.html.
This fix addresses the issue by changing
checks to
checks.
Note that I have not verified whether similar issue exists in other locations where
instanceofis used. In particular, one other suspectible use case iserr instanceof Errorwhich occurs a lot in the code base. The issue would only occur if the instance tested had been created in a different node.js module that the module performing the test.