typo in db.authenticate caused a check (for provided connection) to return false, causing a connection AND onAll=true to be passed into __executeQueryCommand downstream. #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… loop that itterates to the number of conns, causing the same conn to be used based on the number of connections returned from all raw conns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The typo (introduced by me... ugh... sorry) in authenticate caused the __executeQueryCommand to run with both options of onAll (connections) and with a connection specified. This caused the same connection to be used repeatedly (equal to the number returned from replset.getAllRawConnections). I can't see any reason for the "override" to exist, so I removed it, as it seems to only cause the same connection to be used again and again. In any case, this issue shows up during the _validateReplicaset... which is why it can be avoided by turning off the haInterval checks.
I couldn't think of a good way to write a failing test for this one... but perhaps I can come up with something this weekend. I just wanted to get a fix in (to at least communicate the issue - to Aaron) even if not accepted.