removed the double wrap, by not passing an Error object to the wrap function. #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…unction. fixes #824 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
wrap was being passed an Error object containing the MongoError, but wrap expects a MongoError document alone which it will wrap in an Error object. In this case, findOne was putting the MongoError document into an Error object and then also handing that Error object to wrap, which would then new up another Error object and use the input Error as the message.
I couldn't find any other instances of this issue other than this one (in findOne).
Possibly could check for instanceOf Error within wrap to double check and then unwrap (i.e. pull the message) and rewrap.