fixed; passing noOpen option to connect()

[aheckmann]

closes #841

[christkv]

won't work as there is no way to identify what kind of server you are connecting to the code below that actually tests to see if its a single server or mongos. Nothing in the uri can determine that so it's not possible to do this and was the reason I removed it in the first place.

[aheckmann]

? the test failed before. now it passes. what doesn't work?

[christkv]

actually it would work but I'm questioning if the whole noOpen parameter makes sense as we need to open the connection anyway to check if it's a mongos or mongod thus it would only really not connect the last db object it returns. See the dilema ?

[aheckmann]

either we should fix it or remove it. as it stands its broken. if we don't
have any sort of noOpen feature anywhere else we should remove it.

On Wed, Jan 9, 2013 at 2:09 PM, Christian Amor Kvalheim <
notifications@github.com> wrote:

actually it would work but I'm questioning if the whole noOpen parameter
makes sense as we need to open the connection anyway to check if it's a
mongos or mongod thus it would only really not connect the last db object
it returns. See the dilema ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/842#issuecomment-12069518.

Aaron
@aaronheckmann https://twitter.com/#!/aaronheckmann

[christkv]

out it goes as it does not make sense anymore. It's like closing the barn door after the horse has bolted. Feel free to add a pull request for the removal and I'll merge it tomorrow morning.

On Jan 9, 2013, at 11:15 PM, Aaron Heckmann wrote:

either we should fix it or remove it. as it stands its broken. if we don't
have any sort of noOpen feature anywhere else we should remove it.

On Wed, Jan 9, 2013 at 2:09 PM, Christian Amor Kvalheim <
notifications@github.com> wrote:

actually it would work but I'm questioning if the whole noOpen parameter
makes sense as we need to open the connection anyway to check if it's a
mongos or mongod thus it would only really not connect the last db object
it returns. See the dilema ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/842#issuecomment-12069518.

Aaron
@aaronheckmann https://twitter.com/#!/aaronheckmann
—
Reply to this email directly or view it on GitHub.

[aheckmann]

removed it.