Fix async callback handling issue #909
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Inner Logic of
_executeQueryCommandresult looks as:It means that eventual error thrown within callback is propagated back to same callback. That's unexpected, additionally in that case async function callback is called twice, which should never happen.
This patch fixes that to:
Callback is not called with it's own error, and error is freely thrown as it should in such case.