Skip to content

Conversation

@gfx
Copy link
Member

@gfx gfx commented Jun 5, 2019

To ensure to support multiple nodejs versions, introduce the matrix.include section.

https://docs.travis-ci.com/user/build-matrix/

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #60 +/- ## ========================================= + Coverage 96.57% 96.9% +0.33%  ========================================= Files 15 15 Lines 905 905 Branches 183 183 ========================================= + Hits 874 877 +3  + Misses 31 28 -3
Impacted Files Coverage Δ
src/Decoder.ts 97.69% <0%> (+0.28%) ⬆️
src/utils/utf8.ts 98.82% <0%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f64c0...32b1890. Read the comment docs.

@gfx gfx force-pushed the ci_matrix_for_node_versions branch from 9656b83 to 32b1890 Compare June 5, 2019 00:57
@gfx gfx added the Tests label Jun 5, 2019
@gfx
Copy link
Member Author

gfx commented Jun 5, 2019

Test coverage has been improved because NodeJS v12 has TextEncoder while lts/* (= NodeJS v10) doesn't.

@gfx gfx merged commit 6e0069d into master Jun 5, 2019
@gfx gfx deleted the ci_matrix_for_node_versions branch June 5, 2019 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants