Skip to content

experimental string cache in encoder but it's slow #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

experimental string cache in encoder but it's slow #62

wants to merge 1 commit into from

Conversation

@gfx
Copy link
Member

@gfx gfx commented Jun 7, 2019 •
edited
Loading

This is an Encoder version of #54 but it makes encode() to be slower.

no cache:

$ npx ts-node benchmark/string.ts encode ascii: 1624.344ms decode ascii: 505.599ms encode / decode emoji data.length=16 encoded.byteLength=34 encode emoji: 1569.745ms decode emoji: 368.443ms

with cache:

$ npx ts-node benchmark/string.ts encode / decode ascii data.length=30 encoded.byteLength=31 encode ascii: 2075.262ms decode ascii: 473.800ms encode / decode emoji data.length=16 encoded.byteLength=34 encode emoji: 1648.992ms decode emoji: 376.590ms

cc: @sergeyzenchenko
@gfx gfx closed this Jun 7, 2019
@sergeyzenchenko
Copy link
Collaborator

sergeyzenchenko commented Jun 17, 2020

@gfx Haha I missed it will take a look at this code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@gfx @sergeyzenchenko