Create sulcus alpha and light source for brain plots #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vinaysraghavan changed the title 
Collaborator Author
  vs   |
| self.sulc_alpha = 1.0 | ||
| except Exception as e: | ||
| logger.warning(f'No {hemi}.sulc file found. No sulcus information will be used.') | ||
| self.sulc = None |
Collaborator
There was a problem hiding this comment.
Maybe add self.sulc_alpha = 1.0 after line 127 also, or just put it after and separate from the "try-except" block? Just in case someone calls plot_hemi, it will automatically fail because it tries to do surfdist_viz and plug in self.sulc_alpha but it won't exist, so it's best to set it to something I think
Collaborator Author
There was a problem hiding this comment.
Oh yeah, good call. Changed
gavinmischler approved these changes Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Allows the user to manually set the alpha transparency of the background of brain plot.
This is useful for making the sulci and gyri coloring less prominent, so they don't distract from colormap differences.
Any other comments?