feat: show feedback only on error #16040
Merged
+9 −79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 tasks
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96 force-pushed the feat/show-feedback-only-on-error branch from 0a2d3a4 to c04a70b Compare Signed-off-by: alperozturk <alper_ozturk@proton.me>
| APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16040.apk |
| test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16040-Unit-test-08-05 |
| blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request removes several messages to reduce visual noise in the app.
Removed messages
Exporting files:
“File will be exported. See notification for details.”
Moving files:
“All files were moved”
Switching accounts:
“Logged in as …”
Restoring a file version:
“Successfully restored file version.”
Displaying helper text in PDF preview: “Tap on a page to zoom in”.