fix(core): Exit with error when generator options not properly parsed #33691
+4 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/nx/src/utils/params.ts Outdated
Comment on lines 926 to 930
| `Could not properly parse prompts. Error:\n${JSON.stringify( | ||
| e, | ||
| null, | ||
| 2 | ||
| )}` |
Contributor
There was a problem hiding this comment.
JSON.stringify() on Error objects returns "{}" because Error properties are not enumerable. This will hide the actual error details from users.
Fix by using the error message directly or converting to a plain object:
console.error( `Could not properly parse prompts. Error:\n${e.message || e}` );Or to include stack trace:
console.error( `Could not properly parse prompts. Error:\n${e.stack || e.message || e}` ); Suggested change
| `Could not properly parse prompts. Error:\n${JSON.stringify( | |
| e, | |
| null, | |
| 2 | |
| )}` | |
| `Could not properly parse prompts. Error:\n${e.stack || e.message || e}` |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
mpsanchis force-pushed the fail-generator-parsing branch from f9f6956 to 21a14f0 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Current Behavior
If there are issues with values passed to generators via prompt, we still see a green output and exit code 0.
A colleague found out about this by pressing
Ctrl+Cwhen being prompted for parameters for a generator, and this led to the CLI simply continuing execution and showing no issue.Expected Behavior
CLI fails.