Skip to content

Use eslint-plugin-redos #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+100 −6
Open

Use eslint-plugin-redos #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import eslint from '@eslint/js';
import importPlugin from 'eslint-plugin-import';
import jsdoc from 'eslint-plugin-jsdoc';
import redos from 'eslint-plugin-redos';
import redosDetector from 'eslint-plugin-redos-detector';
import regexpPlugin from 'eslint-plugin-regexp';
import pluginSecurity from 'eslint-plugin-security';
Expand All @@ -21,6 +22,7 @@ export default tseslint.config(
tseslint.configs.stylistic,
jsdoc.configs['flat/recommended'],
pluginSecurity.configs.recommended,
redos.configs.flat.recommended,
regexpPlugin.configs['flat/recommended'],
{
files: ['src/**/*.ts'],
Expand Down
1 change: 1 addition & 0 deletions library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"eslint": "^9.39.1",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jsdoc": "^61.4.0",
"eslint-plugin-redos": "^4.6.0-beta.3",
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eslint-plugin-redos package has a Node.js engine requirement of >=20 (as seen in the pnpm-lock.yaml). Consider adding an engines field to package.json to enforce this requirement and prevent issues for developers using older Node versions:

"engines": { "node": ">=20" }

This will ensure compatibility with the new plugin's requirements.
Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This package is a beta version (4.6.0-beta.3). While the PR description mentions it successfully discovered a vulnerability (EMOJI_REGEX), beta versions may have stability issues or breaking changes. Consider:

  1. Monitoring for a stable release and upgrading once available
  2. Documenting this beta dependency and any known issues
  3. Adding a TODO/comment to track the beta status

If this is intentional for early access to improved ReDoS detection, consider adding a comment in the code explaining why the beta version is acceptable.
Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@makenowjust makenowjust Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 4.6.0-beta supports ESLint flat config, so this version is required.
"eslint-plugin-redos-detector": "^3.1.1",
"eslint-plugin-regexp": "^2.10.0",
"eslint-plugin-security": "^3.0.1",
Expand Down
103 changes: 97 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading