Feat: Update Guest Payments Session presentation mode options #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37b66a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kand reviewed Dec 1, 2025
| }; | ||
| | ||
| export type PayPalGuestPresentationModeOptions = | ||
| PresentationModeOptionsForAuto & { |
Contributor
There was a problem hiding this comment.
Where we going to omit presentationMode here?
Contributor Author
There was a problem hiding this comment.
Oh, I thought we discussed using Omit in the BCDC hook itself and leaving this type unchanged. Something like this, since we want to remove presentationMode from the hook's arguments but still be able to correctly type the option we pass to .start.
Contributor Author
There was a problem hiding this comment.
Discussed with @kand and we are good on this implementation as is currently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.