Skip to content

Split rewrite and do some refactoring so that we have RewritePlan and RewriteExecution #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split rewrite and do some refactoring so that we have RewritePlan and RewriteExecution #564

wants to merge 1 commit into from

Conversation

@jaggederest
Copy link
Contributor

@jaggederest jaggederest commented Oct 16, 2025

This is a speculative refactor so don't burn too many cycles, just mostly interested in strategic feedback.
@jaggederest jaggederest requested a review from levkk October 16, 2025 19:05
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 32.97872% with 63 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/frontend/router/rewrite/mod.rs 37.20% 27 Missing ⚠️
pgdog/src/frontend/client/query_engine/mod.rs 21.05% 15 Missing ⚠️
pgdog/src/frontend/client/query_engine/rewrite.rs 0.00% 11 Missing ⚠️
pgdog/src/frontend/router/parser/query/mod.rs 55.00% 9 Missing ⚠️
pgdog/src/frontend/router/parser/command.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jaggederest