Add IO stats and ext4 FS stats through new ext4 collector #3295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2025
mshahzeb force-pushed the shahzeb/add-io-fs-stats-node branch from f6d2481 to 5ae7077 Compare 
Signed-off-by: Muhammad Shahzeb <mhmdshahzeb1993@gmail.com>
mshahzeb force-pushed the shahzeb/add-io-fs-stats-node branch from b263a71 to e902d2a Compare 
Author
| Hey! Can you pls give this a review whenever you can. Thanks! |
SuperQ requested changes Apr 19, 2025
| } | ||
| | ||
| // Read IO error counts if available | ||
| iodoneCnt, err := os.ReadFile(filepath.Join(*sysPath, "block", dev, "device/iodone_cnt")) |
Member
There was a problem hiding this comment.
This needs to be implemented in the procfs library first.
There was a problem hiding this comment.
Naively it looks like prometheus/procfs#651 merged, is this PR in need of a new owner? Found this PR via the associated issue 😅
| Having support for xfs filesystem would be greatly appreciated |
Member
| If @mshahzeb is not interested in continuing this, feel free to submit a new PR based on prometheus/procfs#651 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Opened in place of: #3047
Fixes: #3005
Adds:
From
/sys/fs/ext4/<partition>/errors_count: number of ext4 errors (commit)/sys/fs/ext4/<partition>/warning_count: number of ext4 warning log messages (commit)/sys/fs/ext4/<partition>/msg_count: number of other ext4 log messagesand
From
/sys/block/<disk>/device/ioerr_cnt: number of SCSI commands that completed with an error/sys/block/<disk>/device/iodone_cnt: number of completed or rejected SCSI commandsImplements new
ext4collector.Corresponding procfs changes: prometheus/procfs#651