Fix normalize by coil currents #319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jons-pf reviewed May 13, 2025
| } | ||
| } | ||
| } | ||
| absl::Status status = NumWindingsToCircuitCurrents(magnetic_configuration); |
Collaborator
There was a problem hiding this comment.
I don't think this is the right place to do this. The import should store the 4th column in num_windings. The migration into the circuit currents, for the normalization to work in the response table computation, should be done only there and not here, I think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why?
normalize_by_coil_currentshad no effect on the resulting response table. I believe there was a mixup of what was meant withnum_windingsandcurrent.Loading a polygon filament with 4 fields per row, e.g.
resulted in
num_windings=1e6andcurrent=1. When normalizing, only current was taken into account and notnum_windings.