MODULES-5123 Fixed compatibility w/ puppetlabs-postgresql 5.0.0 #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
|
|
Author
| @baurmatt It's not necessary, because the database_port param does't have a validator But if you want it, it's okay. |
Contributor
| True, but https://github.com/puppetlabs/puppetlabs-postgresql/blob/5.0.0/manifests/server/grant.pp#L10 needs has a validation :( |
Author
| @baurmatt Maybe I do not hit this error because I updated a already working puppetdb. Thanks for the hints. |
Author
| Hum, looks like test failures are not related to this issue.. |
Contributor
| this should also get noted in metadata.json then, 👍 otherwise |
Author
| Sure. |
Contributor
| Thanks for this PR! I ended up merging a different one that did the same thing, but appreciate the contribution. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://tickets.puppetlabs.com/browse/MODULES-5123