Insert Instructions at the end of System Prompt #3614
+35 −10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 tasks
DouweM requested changes Dec 2, 2025
Collaborator
DouweM left a comment
DouweM left a comment There was a problem hiding this comment.
@siddhantbhagat8 Thanks Siddhant! Please look at my notes and add a test in test_agent.py, by using both system_prompt and instructions decorators on one agent
| """Just maps a `pydantic_ai.Message` to a `cohere.ChatMessageV2`.""" | ||
| cohere_messages: list[ChatMessageV2] = [] | ||
| system_prompt_count = sum( | ||
| 1 for m in messages if isinstance(m, ModelRequest) for p in m.parts if isinstance(p, SystemPromptPart) |
Collaborator
There was a problem hiding this comment.
This will result in a wrong index when the system prompt parts are not all of the beginning, and it seems brittle to use an index derived from Pydantic AI messages in a list named cohere_messages, which may or may not map 1:1. So I think we should count system parts at the start of the actual cohere_messages list instead
| """Just maps a `pydantic_ai.Message` to a `groq.types.ChatCompletionMessageParam`.""" | ||
| groq_messages: list[chat.ChatCompletionMessageParam] = [] | ||
| system_prompt_count = sum( | ||
| 1 for m in messages if isinstance(m, ModelRequest) for p in m.parts if isinstance(p, SystemPromptPart) |
| """Just maps a `pydantic_ai.Message` to a `huggingface_hub.ChatCompletionInputMessage`.""" | ||
| hf_messages: list[ChatCompletionInputMessage | ChatCompletionOutputMessage] = [] | ||
| system_prompt_count = sum( | ||
| 1 for m in messages if isinstance(m, ModelRequest) for p in m.parts if isinstance(p, SystemPromptPart) |
| ) -> list[MistralMessages]: | ||
| """Just maps a `pydantic_ai.Message` to a `MistralMessage`.""" | ||
| mistral_messages: list[MistralMessages] = [] | ||
| system_prompt_count = sum( |
| for message in messages: | ||
| for part in message.parts: | ||
| if isinstance(part, SystemPromptPart): | ||
| system_prompt_count += 1 |
| assert isinstance(instructions, str) | ||
| openai_messages.insert(0, responses.EasyInputMessageParam(role='system', content=instructions)) | ||
| system_prompt_count = sum( | ||
| 1 for m in messages if isinstance(m, ModelRequest) for p in m.parts if isinstance(p, SystemPromptPart) |
Collaborator
There was a problem hiding this comment.
And here as well. We should find the right index in the actual openai_messages list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Changed the insertion logic to insert instructions after all system prompt parts
Simple append:
anthropic.pygoogle.pygemini.pybedrock.pyInsert at a particular position:
For models that build a messages list, count
SystemPromptPartinstances and insert at that indexopenai.pycohere.pygroq.pymistral.pyhuggingface.pyTesting
I ran the tests locally, everything passed. If I should add a test for this change, please let me know the correct location for the test :)