Added zip extractor folder #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pawangeek requested changes Oct 9, 2020
Contributor
pawangeek left a comment
pawangeek left a comment There was a problem hiding this comment.
Correct requirements.txt
Contributor Author
| @pawangeek what I have to do? |
pawangeek reviewed Oct 9, 2020
zip_extractor/requirements.txt Outdated
| @@ -0,0 +1,2 @@ | |||
| zipfile37 | |||
Contributor Author
There was a problem hiding this comment.
It is the library name. Can I leave the library names as just "zipfile"
Contributor
There was a problem hiding this comment.
But what about the version. You can use "pip freeze > requiements.txt" to check that
Contributor Author
There was a problem hiding this comment.
I don't know that feature. If you know that can you update the readme file.
Contributor
There was a problem hiding this comment.
ok, that's an inbuilt library. My bad
Closed
2 tasks
pawangeek approved these changes Oct 9, 2020
pawangeek added the hacktoberfest-accepted Contributor Author
| Thank you so much @pawangeek |
Contributor Author
| Can I have your linkedin profile id so that we can talk related to these kind of stuff? |
Contributor
| You can use @pkjains to ping me on telegram. LinkedIn is not suitable for this kind of stuff |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull Request Template
script name - zip_extractor
What have you Changed
what you changed in the codebase.write here
Created a folder with zip extractor python script along with requirements.txt and readme.md files
Issue no.(must) - #33
Self Check(Tick After Making pull Request)
If issue was not assigned to you Please don't make a PR. It will marked as invalid.