Skip to content

Add URL shortener Script #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2020
Merged

Add URL shortener Script #40

merged 1 commit into from
Oct 8, 2020

Conversation

@hpnightowl
Copy link
Contributor

@hpnightowl hpnightowl commented Oct 8, 2020

Pull Request Template

script name - URL Shortner

What have you Changed

Added a Script that will convert a given URL to a Tiny URL with the use of map funtion as mentioned in issue #7

Issue no.(must) -

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
@pawangeek
Copy link
Contributor

pawangeek commented Oct 8, 2020

Hey, can you please rename your readme file to README.md?
@pawangeek pawangeek linked an issue Oct 8, 2020 that may be closed by this pull request
URL shortener #7
Closed
2 tasks
@pawangeek pawangeek self-requested a review October 8, 2020 11:08
@hpnightowl
Copy link
Contributor Author

hpnightowl commented Oct 8, 2020

ok
@hpnightowl
Copy link
Contributor Author

hpnightowl commented Oct 8, 2020

@pawangeek done anything more?
@pawangeek
Copy link
Contributor

pawangeek commented Oct 8, 2020

Hey @hpnightowl, thanks for your contribution. Leave a star if you enjoy that :)
@pawangeek pawangeek added the hacktoberfest-accepted Supporting completion of hacktober fest label Oct 8, 2020
@pawangeek pawangeek merged commit 38258bc into python-geeks:main Oct 8, 2020
@hpnightowl
Copy link
Contributor Author

hpnightowl commented Oct 8, 2020

Preview

Screenshot (73)
@pawangeek pawangeek removed their request for review October 9, 2020 07:10
@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Closed
@python-geeks python-geeks deleted a comment from allcontributors bot Oct 9, 2020
@pawangeek
Copy link
Contributor

pawangeek commented Oct 9, 2020

@all-contributors please add @hpnightowl for code
@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Oct 9, 2020

@pawangeek

I've put up a pull request to add @hpnightowl! 🎉
@maxily1 maxily1 added the tested: working Script working properly label Oct 13, 2020
@pawangeek pawangeek mentioned this pull request Aug 22, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Supporting completion of hacktober fest tested: working Script working properly

3 participants

@hpnightowl @pawangeek @maxily1