Skip to content

Conversation

@clarete
Copy link

@clarete clarete commented Nov 18, 2013

No description provided.

@clarete
Copy link
Author

clarete commented Nov 18, 2013

Let me know if you think it's a good idea to just show the report instead of generating the html file. I can change that in this patch as well. Thanks for the awesome lib :)

@clarete
Copy link
Author

clarete commented Nov 18, 2013

This is how it looks with the patch!

screen shot 2013-11-18 at 10 04 04 am

@Julian
Copy link
Member

Julian commented Nov 18, 2013

Hey, thanks!

Adding coverage report to the output is fine with me certainly. AFAIU though we don't need to call coverage erase, as long as you don't pass --append coverage run will do that for us. Is there a reason you think we need it?

Also we shouldn't omit coverage on tests, it's important to run coverage on everything, and in particular tests, to make sure they're all executed.

But yeah, adding coverage report sounds great.

@Julian Julian closed this Dec 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants