RefResolver updates #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add cache_remote flag to init to turn it off
Add ability to specify handlers for different uri schemes in RefResolver Add unit tests for new features
Contributor Author
| @Julian Look ok? |
jsonschema.py Outdated
Member
There was a problem hiding this comment.
What's the thing in requests that's causing this? Can we check for that instead?
Member
| Other than those two nitpicks, this looks good to merge. Although it'd be lovely if you added some prose docs on this to docs/references.rst |
Member
| Sorry, that was not enthusiastic. I meant "this looks really nice :)". |
Remove backslash line continuation
Contributor Author
| Two issues with requests version, really old requests didn't have json loading, and the api in 1.0 changed from it being a property to a method. I have it checking both those things explicitly now. I need to brush up on my rst, I'll look into adding to the references docs after I eat. |
Member
| OK :) Merge when ready. Thank you! |
Contributor Author
| I'll send another PR tomorrow with doc updates. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Couple things in here: