improve Kredis::Types::List #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits March 31, 2024 11:09
allow to pass range to List#elements. fix List#last to return typed.
Author
| any chance someone can review it? |
jeremy requested changes Apr 19, 2025
lib/kredis/types/list.rb Outdated
| | ||
| def elements | ||
| strings_to_types(lrange(0, -1) || [], typed) | ||
| def elements(start = 0, stop = -1) |
Member
There was a problem hiding this comment.
Rather than give slicing arguments to #elements, would introduce #slice and have #elements call it.
| @list.append [ 1.day.from_now.midnight.in_time_zone("Pacific Time (US & Canada)"), 2.days.from_now.midnight.in_time_zone("UTC") ] | ||
| assert_equal [ 1.day.from_now.midnight, 2.days.from_now.midnight ], @list.elements | ||
| test "size" do | ||
| @list.clear |
Member
There was a problem hiding this comment.
Would assert_equal 0, @list.size here rather than having a separate test for size after removal.
remove extra #clear test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Several
Listimprovements.