Replace QuickJS with Zipline #2256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
QuickJS was renamed to Zipline all the way back in 2021. Unlike old QuickJS, newer Zipline versions are 16kb aligned. Current Zipline is also compatible back to minSdk 21.
Contributor Author
| It actually looks like the only extension that even used this no longer exists anymore. @phisher98 is this even still necessary to exist? |
Contributor
| It's good to have I think if needed to deof js like webcrack else it's upto u guys @Luna712 |
Contributor Author
| We can just keep this in that case unless @fire-light42 feels differently? But since it's not currently used right now also, this should be able to merged and is a no-op that shouldn't cause any issues at all with any extensions etc... (even though its mostly the same as QuickJS imports would need a different package so if ut was actually used this PR would be a bit more difficult, but since it isn't right now it should be easy to merge) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
QuickJS was renamed to Zipline all the way back in 2021. Unlike old QuickJS, newer Zipline versions are 16kb aligned. Current Zipline is also compatible back to minSdk 21.