Fix DisableIdentity and IdentitySuffix option forwarding" #2923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
snigle approved these changes Feb 20, 2024
| why this still open ? |
Member
| renaming planned for v10, sentinel (failover) should be fixed in master. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #2911
DisableIdentity and IdentitySuffix options are not correctly forwarded by sentinelOptions and clusterOptions.
Because 9.5.0 now uses redis 7.2 setinfo options by default, this breakd older redis versions unless DisableIdentity is used.
It still breakd FailoverClients since DisableIdentity is not forwarded to base client.