Skip to content

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Feb 3, 2022

This pull request

  • adds support for the optional checks key in required_status_checks

πŸ’β€β™‚οΈ For reference, see https://docs.github.com/en/rest/reference/branches#update-branch-protection.

CleanShot 2022-02-03 at 13 37 24@2x


View rendered README.md

@vercel
Copy link

vercel bot commented Feb 3, 2022

@localheinz is attempting to deploy a commit to the Probot Team on Vercel.

A member of the Team first needs to authorize it.

@localheinz
Copy link
Contributor Author

As far as I can tell, this already works out of the box, so in other words, this pull request only documents the deprecated changes.

❗ I have not tried to find out whether the GitHub API rejects requests where both checks and contexts are present.

Comment on lines +147 to 148
# Required. Deprecated. The list of status checks to require in order to merge into this branch. If any of these checks have recently been set by a particular GitHub App, they will be required to come from that app in future for the branch to merge. Use checks instead of contexts for more fine-grained control.
contexts: []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Required. Deprecated. The list of status checks to require in order to merge into this branch. If any of these checks have recently been set by a particular GitHub App, they will be required to come from that app in future for the branch to merge. Use checks instead of contexts for more fine-grained control.
contexts: []

I'd just remove this entirely. It works, I tested. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants