Skip to content

RRD footers 2: RRD manifests #12047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 3, 2025
Merged

RRD footers 2: RRD manifests #12047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5218066
protobuf definitions for RRD manifest
teh-cmc Dec 2, 2025
d3fbe90
native types and transport2app conversions
teh-cmc Dec 2, 2025
2bd3f75
add logic to build out RRD manifest from chunks
teh-cmc Dec 2, 2025
23ab771
reusing schema hashing logic in re_server
teh-cmc Dec 2, 2025
8a2b8c2
Update crates/store/re_log_encoding/src/transport_to_app.rs
teh-cmc Dec 2, 2025
ffba203
footer_roundtrip.rs -> footers_and_manifests.rs
teh-cmc Dec 2, 2025
470fcf7
add test for a simple manifest
teh-cmc Dec 2, 2025
0914996
snapshots
teh-cmc Dec 2, 2025
3b2b6bb
more cargo
teh-cmc Dec 2, 2025
4bf1d03
inject some duration and timestamp timelines into the mix
teh-cmc Dec 2, 2025
6e1bf96
Apply suggestions from code review
teh-cmc Dec 2, 2025
fd1e2ef
codegen
teh-cmc Dec 2, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9073,11 +9073,13 @@ dependencies = [
"bytes",
"criterion",
"ehttp",
"insta",
"itertools 0.14.0",
"js-sys",
"lz4_flex 0.12.0",
"mimalloc",
"parking_lot",
"re_arrow_util",
"re_build_info",
"re_chunk",
"re_log",
Expand All @@ -9088,6 +9090,8 @@ dependencies = [
"re_span",
"re_tracing",
"re_types",
"re_types_core",
"sha2",
"similar-asserts",
"thiserror 2.0.17",
"tokio",
Expand Down Expand Up @@ -9623,7 +9627,6 @@ dependencies = [
"re_tuid",
"re_types_core",
"serde",
"sha2",
"tempfile",
"thiserror 2.0.17",
"tokio",
Expand Down
4 changes: 4 additions & 0 deletions crates/store/re_log_encoding/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ stream_from_http = [
[dependencies]

# Rerun:
re_arrow_util.workspace = true
re_build_info.workspace = true
re_chunk.workspace = true
re_log_types.workspace = true
Expand All @@ -51,12 +52,14 @@ re_smart_channel.workspace = true
re_sorbet.workspace = true
re_span.workspace = true
re_tracing.workspace = true
re_types_core.workspace = true

# External:
arrow = { workspace = true, features = ["ipc"] }
itertools.workspace = true
lz4_flex = { workspace = true }
parking_lot.workspace = true
sha2.workspace = true
thiserror.workspace = true
tracing.workspace = true
xxhash-rust.workspace = true
Expand All @@ -79,6 +82,7 @@ web-sys = { workspace = true, optional = true, features = ["Window", "MessageEve
re_types.workspace = true

criterion.workspace = true
insta.workspace = true
mimalloc.workspace = true
similar-asserts.workspace = true

Expand Down
4 changes: 3 additions & 1 deletion crates/store/re_log_encoding/src/rrd/encoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ impl FooterState {

#[expect(clippy::unnecessary_wraps, clippy::unused_self)] // won't stay for long
fn finish(self) -> Result<crate::RrdFooter, EncodeError> {
Ok(crate::RrdFooter {})
Ok(crate::RrdFooter {
manifests: Default::default(),
})
}
}

Expand Down
Loading
Loading