Fix for rust nightly #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Creating nlist and clist with &mut Threads::new causes Rust to complain. Create them without pointer indirection at first, and change corresponding function calls to reference them as pointers instead.
Member
| I'm a little confused by github right now, it says this can merge cleanly but I think I already fixed this in 6c0f8aa, so I'm not totally sure what's going on! Regardless, I think this fix is already in master, so just be sure to run |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix for breaking lifetime changes introduced on the 27th.
Of note: tests do pass, but only build if linked against a libregex and a libregex_macros that wasn't built as a test. Building the tests against a libregex_macros built with --test causes Rust to complain about regex($re) to not live long enough.
I'm not entirely sure as to the cause, but given compiler plugins are experimental it isn't entirely surprising.