Skip to content

Update to rust master: fixed array length fixes + lib stabilizations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2015
Merged

Update to rust master: fixed array length fixes + lib stabilizations #7

merged 1 commit into from
Jan 3, 2015

Conversation

@vhbit
Copy link
Contributor

@vhbit vhbit commented Jan 3, 2015

No description provided.

@pyfisch
Copy link

pyfisch commented Jan 3, 2015

Build passes.
But tests still fail to build for me.

tests/bench.rs:36:14: 36:26 error: expected one of `+`, `::`, `;`, or `]`, found `,` tests/bench.rs:36 let re = regex!("y");
@vhbit
Copy link
Contributor Author

vhbit commented Jan 3, 2015

It looks pretty much like an error from fixed length array change, but I can't test yet as I have a local dylib mess and regex_macros fails to build at all.
@vhbit
Copy link
Contributor Author

vhbit commented Jan 3, 2015

@pyfisch I've pushed an update, can you test it as I'm not sure how long it will take to solve dylib issue?
@pyfisch
Copy link

pyfisch commented Jan 3, 2015

All builds pass. (Like on travis) for ac2a0dc
@vhbit vhbit changed the title Fallout of cmp changes Update to rust master: fixed array length fixes + lib stabilizations Jan 3, 2015
@vhbit
Update to rust master:
72290b7 
- fixed length array syntax fallout - problems caused by library stabilization - deriving -> derive - {mod} -> {self}
@pyfisch
Copy link

pyfisch commented Jan 3, 2015

All is ok.
The deprecated things can probably changed in a separate pr.

  • deprecated syntax; use the self keyword now
  • deriving is deprecated; use derive

EDIT: Um you are to fast.
@vhbit
Copy link
Contributor Author

vhbit commented Jan 3, 2015

Pushed update for deprecation just a couple seconds ago 😄
@reem reem mentioned this pull request Jan 3, 2015
Closed
@alexcrichton
Copy link
Member

alexcrichton commented Jan 3, 2015

Thanks!
alexcrichton added a commit that referenced this pull request Jan 3, 2015
@alexcrichton
Merge pull request #7 from vhbit/cmp-fallout
eac4cbf 
Update to rust master: fixed array length fixes + lib stabilizations
@alexcrichton alexcrichton merged commit eac4cbf into rust-lang:master Jan 3, 2015
@vhbit vhbit deleted the cmp-fallout branch January 3, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@vhbit @pyfisch @alexcrichton