Migration rewrites for infix arguments interpreted as named tuples #21949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Matt Bovel <matthieu@bovel.net>
WojciechMazur added the backport:nominated 
WojciechMazur added a commit that referenced this pull request Nov 18, 2024
…21949) Best effort migration rewrites based on prior work in #21565 At this point, it's too late to deprecate named infix arguments. Let's produce warnings instead. We accept infix arguments that might be an argument of a named tuple, eg. `zip`, `++` or `==` - each of these takes a single argument with NamedTuple. --------- Co-authored-by: Som Snytt <som.snytt@gmail.com> Co-authored-by: Matt Bovel <matthieu@bovel.net> [Cherry-picked 5d5a9e6]
WojciechMazur added backport:accepted WojciechMazur added backport:done KacperFKorban pushed a commit to dotty-staging/dotty that referenced this pull request Nov 20, 2024
…cala#21949) Best effort migration rewrites based on prior work in scala#21565 At this point, it's too late to deprecate named infix arguments. Let's produce warnings instead. We accept infix arguments that might be an argument of a named tuple, eg. `zip`, `++` or `==` - each of these takes a single argument with NamedTuple. --------- Co-authored-by: Som Snytt <som.snytt@gmail.com> Co-authored-by: Matt Bovel <matthieu@bovel.net>
WojciechMazur added a commit that referenced this pull request Nov 28, 2024
Resolves #22042 * Reverts most of the stabilization changes introduced in #21680 excluding bugfixes introduced when stabilizing the name tuples * Adapts #21823 and #21949 warnings to make them both syntax deprecations instead of ambiguous syntax. * Adds automatic rewrite to #21823 to replace `(foo = bar)` into `{foo = bar}`
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this pull request Nov 29, 2024
…cala#21949) Best effort migration rewrites based on prior work in scala#21565 At this point, it's too late to deprecate named infix arguments. Let's produce warnings instead. We accept infix arguments that might be an argument of a named tuple, eg. `zip`, `++` or `==` - each of these takes a single argument with NamedTuple. --------- Co-authored-by: Som Snytt <som.snytt@gmail.com> Co-authored-by: Matt Bovel <matthieu@bovel.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #21681
Resolves #21767 - fixes 5 out of 6 referenced projects. The only still failing project
tarao/record4sis mostly made obsolete under Scala 3.6. It was defining a named tuples-like DSLBest effort migration rewrites based on prior work in #21565
At this point, it's too late to deprecate named infix arguments. Let's produce warnings instead. We accept infix arguments that might be an argument of a named tuple, eg.
zip,++or==- each of these takes a single argument with NamedTuple.If accepted it should be backported to 3.6