Check inline expansion for exclusion #23019
Open
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #23018
Preserve attachments on literals, check inline expansions for them, and avoid warning about purity when an inline expansion is a constant unit literal (such as
assert(true)and similar reductions).(The lint for "non-unit value in statement position" specifically does not warn. However, the purity check still warns for explicit parens, since they may have been intended as part of an application.)
Scala 2 warns at refchecks and at that time drills into the tree shapes that may have the attachment.
The test shows status quo, where42: Unitincorrectly warns, ironically.