chore: use empathic for package traversal #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since we disable normalisation, we're essentially traversing upwards for the `package.json` and reading it as-is. We can use a much faster and smaller library for this (empathic in this case). Since empathic is generic (i.e. can find any file upwards), it'll also de-dupe nicely in dependency trees as adoption increases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since we disable normalisation, we're essentially traversing upwards for
the
package.jsonand reading it as-is. We can use a much faster andsmaller library for this (empathic in this case).
Since empathic is generic (i.e. can find any file upwards), it'll also
de-dupe nicely in dependency trees as adoption increases.