Add literal 'null', 'true' and 'false' consts to RawValue struct. #1221
+9 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Published in serde_json 1.0.134. I was waiting to publish this because I was not happy with how rustdoc originally rendered these. rust-lang/rust#134321 |
Contributor Author
| No worries, there's no rush on a release for me. I didn't realize that Rustdoc rendered each impl literally. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have been using
RawValuea lot lately to implement server endpoints that accept large JSON objects, extract some specific fields and ultimately save the entire JSON to the DB.As part of this process, a proc-macro based JSON pre-processor is used to automate HTTP error responses. This also uses
RawValueto avoid allocating when traversing unknown JSON data.The pre-processor uses literal "null"'s as part of it's logic, and at the moment I'm deserializing a literal
"null"string toRawValueevery time I need one.This could be done once and stored in a
LazyLockor something similar, but I thought that adding literal values to theRawValuestruct is the least complex solution.What do you think?