Added support for MultipartFile #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Add factory for Param.Expander using ConversionService. Instances use ConversionService and passes annotations (through TypeDescriptor) - ConversionService can now pick up @DateTimeFormat and @numberformat and convert the params applying those.
| @Hronom Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
| @Hronom Thank you for signing the Contributor License Agreement! |
Codecov Report
@@ Coverage Diff @@ ## master #65 +/- ## ============================================ + Coverage 75.87% 76.02% +0.15% - Complexity 283 286 +3 ============================================ Files 36 36 Lines 1206 1214 +8 Branches 186 188 +2 ============================================ + Hits 915 923 +8 Misses 212 212 Partials 79 79
|
Contributor
| Can you submit this PR against the 2.0.x branch? |
Contributor Author
| @ryanjbaxter changed |
Contributor Author
| @ryanjbaxter Oh I think I need to apply changes on that branch since it will push some changes from master... |
Contributor Author
| Closed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed solution for #62
Notes
The solution is based on
Class
feign.form.spring.SpringFormEncoderwas added insideorg.springframework.cloud.openfeign.support.SpringEncoderbecause it's doesn't has some checks:Check of
bodyTypeon null.org.springframework.cloud.openfeign.support.SpringEncoder#encodedon't handle situation whenbodyTypeis null.No check for content type
multipart/form-datain header.feign.form.FormEncoderrequiresmultipart/form-datain header for proper processing.All this checks added and tests are passed.