Move sidecars into gitops #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com>
* Update Istio to 1.12.0 * add namespace (required for 1.12) Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com> Co-authored-by: therealmitchconnors <mitchconnors@gmail.com>
Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com>
Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com>
* Update Istio to 1.12.0 * add namespace (required for 1.12) * remove injection annotation on operator ns Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com> Co-authored-by: therealmitchconnors <mitchconnors@gmail.com>
* Update Istio to 1.12.0 * add namespace (required for 1.12) * remove injection annotation on operator ns * Update Sidecars to 1.12.0 Co-authored-by: therealmitchconnors <therealmitchconnors@users.noreply.github.com> Co-authored-by: therealmitchconnors <mitchconnors@gmail.com>
Collaborator Author
| There were some problems with this branch. I will resubmit after my demo tomorrow. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This turns off automatic sidecar injection, and instead creates the sidecar at the deployment level using github actions, and istioctl kube-inject. Making the sidecar part of the deployment adds more control and certainty to the process, makes the sidecar completely declarative, and allows flagger to progressively shift traffic from one version of the sidecar to the next during an upgrade.
I recommend squashing this, as there are lots of unnecessary commits.
Also, I wasn't able to figure out how to get the github token set up for your update-istio create pull request step, so I'm keeping my main branch slightly off for the demo.