Inject Sidecar via patch #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| @therealmitchconnors your fork is on the old main branch with Istio operator. I can port this PR manually if you don’t have time to rebase and modify the inject jobs to extract the version from istio-version.yaml. |
Collaborator Author
| What branch should I be merging to? kubecon? |
Owner
| Make the PR for main please, i will add the data plane upgrade to the docs afterwards. |
stefanprodan reviewed May 9, 2022
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You can see how this worked on my main branch. I also updated get-istioctl to not accidentally check in the binary.