Skip to content

Conversation

@caesar
Copy link
Contributor

@caesar caesar commented Sep 25, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Implemented by getting the name of the current app from NSRunningApplication and adding it to the menu items labels.

closes #536

@caesar caesar requested a review from a team as a code owner September 25, 2022 00:35
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

Sorry, forgot cargo fmt again… fixed now

@caesar caesar requested a review from amrbashir September 25, 2022 16:00
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

This feels to me like a much cleaner implementation now, thanks for the pointers @amrbashir.

Could you just confirm that you're happy with these changes to the app_name function?

@FabianLars
Copy link
Member

I think that the Option should be reintroduced. You can't really expect that CFBundleName is set in all scenarios

@caesar caesar requested a review from amrbashir September 25, 2022 16:52
@caesar caesar requested a review from amrbashir September 25, 2022 17:23
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

Thanks for all the reviews @amrbashir 🙂

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit 65f768e into tauri-apps:dev Sep 25, 2022
@github-actions github-actions bot mentioned this pull request Sep 25, 2022
@caesar caesar deleted the menus/appname branch September 25, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants