Skip to content

Conversation

@deadprogram
Copy link
Member

Pretty much all the changes needed for the 0.14.0 release.

@aykevl or @jaddr2line we might also want to review some of the pages under https://github.com/tinygo-org/tinygo-site/tree/dev/content/compiler-internals

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the board documentation (I assume it's correct). I did check other changes and have one comment. Other than that, this looks fine.

Yeah, there are probably things that need updating in the compiler internals, I'll need to check that.

unicode/utf16 | <span style="color: green">✔</span> yes |
unicode/utf8 | <span style="color: green">✔</span> yes |
unsafe | <span style="color: green">✔</span> yes |
vendor/golang.org/x/crypto/chacha20poly1305 | <span style="color: green">✔</span> yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess these errors are caused by the switch to Go modules.

use of vendored package not allowed 

I think they can be ignored, none of the existing crypto related packages have stopped compiling. And you shouldn't import these vendor directories anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some code to ignore vendored directories, and regenerated the imports report.

Is this good now, @aykevl ?

Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
Signed-off-by: deadprogram <ron@hybridgroup.com>
…ut vendor Signed-off-by: deadprogram <ron@hybridgroup.com>
@aykevl
Copy link
Member

aykevl commented Aug 3, 2020

Yes looks good now.

@deadprogram
Copy link
Member Author

OK, cool. Now merging into dev.

@deadprogram deadprogram merged commit e1427ed into dev Aug 3, 2020
@deadprogram deadprogram deleted the release-0-14 branch August 3, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants