Skip to content

Conversation

@aykevl
Copy link
Member

@aykevl aykevl commented Jun 28, 2024

Instead of having a separate https://play.tinygo.org, use https://tinygo.org/play that actually integrates into the Docsy theme.

Once this is in, I'd like to make play.tinygo.org just a redirect to tinygo.org/play so that I can modify the default UI.

@aykevl aykevl force-pushed the playground-play branch from d200cb6 to c7353af Compare June 28, 2024 17:07
@aykevl aykevl force-pushed the playground-play branch 2 times, most recently from b852866 to a1b5346 Compare September 5, 2024 13:05
@aykevl aykevl marked this pull request as ready for review September 5, 2024 13:06
@aykevl
Copy link
Member Author

aykevl commented Sep 5, 2024

This now also supports a 'share' button!

There are more playgrounds, so rename this one.
This makes maintenance a lot easier.
@aykevl
Copy link
Member Author

aykevl commented Sep 24, 2024

Rebased after #429 and moved some shared code to a file that's included from multiple places (to avoid excessive duplication).

Ready for review :) I'd like to get this merged as it's pretty big (both the integrated playground and the "share" button).

Copy link
Member

@deadprogram deadprogram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆 this is awesome!

@aykevl aykevl force-pushed the playground-play branch 2 times, most recently from 9367ae3 to 6e55684 Compare September 25, 2024 10:11
@aykevl
Copy link
Member Author

aykevl commented Sep 25, 2024

Updated!
It seems my comment was lost. I wonder whether we should maybe use security@ or privacy@ instead of conduct@tinygo.org? It can be a simple alias of course.

Instead of having a separate play.tinygo.org, use tinygo.org/play that actually integrates into the Docsy theme.
@deadprogram
Copy link
Member

This is fantastic @aykevl now merging!

@deadprogram deadprogram merged commit 75c225d into dev Sep 30, 2024
@deadprogram deadprogram deleted the playground-play branch September 30, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants