machine/nrf51: add ADC implementation #3315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
deadprogram force-pushed the add-nrf51-adc branch from 913aef1 to 4ddab9b Compare Signed-off-by: deadprogram <ron@hybridgroup.com>
deadprogram force-pushed the add-nrf51-adc branch from 4ddab9b to 81e1455 Compare Member Author
| Tested via https://github.com/tinygo-org/tinyhci/blob/4db55685e4607e47f036db95791e249c8ad717bc/microbit/main.go which is part of tinygo-org/tinyhci#10 and worked as expected. |
Member Author
| Here it is passing now! 😸 https://github.com/tinygo-org/tinygo/pull/3315/checks?check_run_id=9720569604 |
| @deadprogram thanks for this PR. I just successfully tested this code with a micro:bit V1.5 and an Octopus Analog Rotation Brick. Works like a charm. The range that I observed is 64 to 65344. |
Member Author
| Thanks for verifying @breml now merging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds the ADC implementation for the
nrf51for boards like the BBC:Microbit and MicrobitV2