Skip to content

boards: use machine.Serial instead of machine.UART0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2021
Merged

boards: use machine.Serial instead of machine.UART0 #5

merged 1 commit into from
May 13, 2021

Conversation

@aykevl
Copy link
Member

@aykevl aykevl commented May 13, 2021

See: tinygo-org/tinygo#1880

Untested, I'm not sure how to run the tests:

$ make all rm -rf build mkdir -p build go build -o build/testrunner tools/testrunner/* tinygo flash -size short -target=itsybitsy-m4 -port=/dev/itsybitsy_m4 ./itsybitsy-m4/ main module (tinygo.org/x/tinyhci) does not contain package tinygo.org/x/tinyhci/itsybitsy-m4 make: *** [Makefile:16: test-itsybitsy-m4] Error 1
@aykevl aykevl mentioned this pull request May 13, 2021
Merged
@deadprogram
Copy link
Member

deadprogram commented May 13, 2021

It needs some tests to test itself, I'm afraid.

I tested on the physical test setup with one of the failing tests, and it passed, so merging. Thanks!
@deadprogram deadprogram merged commit f3c5049 into master May 13, 2021
@deadprogram deadprogram deleted the machine-serial branch May 13, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@aykevl @deadprogram